Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Add libraries of imported targets to wx-config #23390

Closed

Conversation

MaartenBent
Copy link
Contributor

Use the LOCATION_DEBUG or LOCATION_RELEASE property of an imported target (like NanoSVG) to determine the full library path.

Fixes #23373

Use the LOCATION_DEBUG or LOCATION_RELEASE property of an imported target (like NanoSVG)
to determine the full library path.

Fixes wxWidgets#23373
@vadz
Copy link
Contributor

vadz commented Mar 29, 2023

Thanks, I don't think it's worth waiting longer before merging it, so I'll do it in a moment.

@vadz vadz closed this in 8102958 Mar 29, 2023
@MaartenBent
Copy link
Contributor Author

Can you backport this one to 3.2 too?

vadz pushed a commit to vadz/wxWidgets that referenced this pull request Mar 29, 2023
Use the LOCATION_DEBUG or LOCATION_RELEASE property of an imported target (like NanoSVG)
to determine the full library path.

See wxWidgets#23373, wxWidgets#23390.

(cherry picked from commit 8102958)
@MaartenBent MaartenBent deleted the cmake-targets-wxconfig branch April 26, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nanosvg] When NanoSVG is used as a non-header-only library, it's missed from the wx-config file
2 participants